Refactor ElementIdInfo ResponsiveElementInfo.observed_identifier is only present when `ElementIdInfo` is used for overflow_id. Thus, it makes much more sense to put `observed_element` inside `ElementIdInfo`. It makes the code easier to reason about (at least to me :)). I also added an explicit constructor to `ElementIdInfo` so that the compiler catches all cases in which `ElementIdInfo` is instantiated so that we correct the code to use the correct constructor. Bug: 359863838 Change-Id: I17a2a63ac97331ab74c27f4e3cdc555300ca121d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020323 Reviewed-by: David Pennington <dpenning@chromium.org> Commit-Queue: André Bianchessi <abianchessi@chromium.org> Reviewed-by: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/main@{#1385735}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.