Google Git
Sign in
chromium / chromium / src / 8a24bedfa35cd7e47e7cf0ee88f00c95c8c7da11
commit8a24bedfa35cd7e47e7cf0ee88f00c95c8c7da11[log] [tgz]
authorDaniel Bratell <bratell@opera.com>Mon Mar 11 22:53:12 2019
committerCommit Bot <commit-bot@chromium.org>Mon Mar 11 22:53:12 2019
tree8e30e1c925aede1d866a530a30573bf4d6f2ffbc
parenta7463e241d477281069c8c2ffb8108a9d1304abb [diff]
Gave two GetCreateNetworkFactoryCallback unique names

Both content/browser/frame_host and content/browser/worker_host
needed a GetCreateNetworkFactoryCallback and in jumbo builds where
those compiled in the same translation unit, those (identical)
functions clashed.

I see no obvious place to share them and I'm not sure if their
static state should even be merged so this patch just gives
the functions more distinct names. (Improved name suggestions
welcome).

Bug: 927849
Change-Id: Ib6556c42e7bdbba9702fb24a12b7b9c0a1fb93cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472672
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#639683}
2 files changed
tree: 8e30e1c925aede1d866a530a30573bf4d6f2ffbc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .