Google Git
Sign in
chromium / chromium / src / 8aa2e3dfc485c5031eb2c66c82471ef72129a442
commit8aa2e3dfc485c5031eb2c66c82471ef72129a442[log] [tgz]
authorMarkus Handell <handellm@google.com>Thu Nov 10 12:17:35 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 10 12:17:35 2022
treeab63141103ed108b3830e5e7e2d5e996dba1ae44
parent6c50e322b7857c522c45afb6f8e71841720187bc [diff]
VideoTrackRecorder: removed shared ownership & thread join. #1/2

This patch series removes VideoTrackRecorder usage of NonMainThread and
shared VideoTrackRecorder::Encoder ownership.

#1/2: Remove one `origin_task_runner_` dependency. When encoded data is
available we don't really need to funnel that through the
`origin_task_runner_` (which is the IO thread in this patch set) and can
just run the encoded data callback directly, since that's already bound
to the main thread and will arrive safe.

The subsequent patch removes dependency on `origin_task_runner_`
altogether.

This change also fixes an existing test-only TSAN issue.

Bug: 956045
Change-Id: I860556aa7f6556f3ea06afc29c22b3cd410c7799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963305
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1069702}
6 files changed
tree: ab63141103ed108b3830e5e7e2d5e996dba1ae44
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.