Google Git
Sign in
chromium / chromium / src / 8ab5fc5b7a478cf1141f2735d0237e6f3e9d1ef0
commit8ab5fc5b7a478cf1141f2735d0237e6f3e9d1ef0[log] [tgz]
authorAkihiro Ota <akihiroota@chromium.org>Mon Jan 09 02:42:55 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 09 02:42:55 2023
treed94f075825687912aacc9a13c2ea7ee19f55166c
parent80d3740555a942a39203a39de5885a16247c5d91 [diff]
Dictation: Speculative fix for flaky Dictation JS tests

According to the attached bug and the chromium flake portal [1], there
are flaky Dictation JavaScript tests. The most prominent one is
DictationE2ETest.SilencesSpokenFeedbackWhenStarting, which fails
with the following error:

AssertionError: expected '' to equal '_ext_ime_egfdjlfmgnehecnclamagfafdccgfndpdictation'

However, there are other tests that also flake with the same error.

I haven't been able to reproduce these flakes locally, even when
running many tests in parallel. The most likely cause for the flakes
is the NO_FOCUSED_IME timeout, which will stop Dictation (and reset
the active IME) if Dictation doesn't focus a text field before the
timeout runs (which is currently one second). This change attempts to
address the flakes by increasing the NO_FOCUSED_IME timeout so that
we guarantee that Dictation is never stopped by timeouts. We already
do this in C++ tests, so it makes sense to do the same in JS tests.

[1] https://luci-analysis.appspot.com/p/chromium/clusters?q=dictation

AX-Relnotes: N/A
Bug: b:260206802
Change-Id: I7927443514eaeaf3d677f969c3a881a82072af07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4142282
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090186}
2 files changed
tree: d94f075825687912aacc9a13c2ea7ee19f55166c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.