commit | 8ac074aa25d6962e75fb66bc9a494f00a911aa11 | [log] [tgz] |
---|---|---|
author | Sam Goto <goto@chromium.org> | Mon Mar 11 18:54:46 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 11 18:54:46 2024 |
tree | 4048fdf1b7e89cc7d4aa54ae3d6bb99bd225f8af | |
parent | 518ace985b939fd91cac9d74b94714df463087a2 [diff] |
[fedcm] Introduce a permission prompt for the IdP Registration API In this CL, we introduce an IdentityProviderPermissionRequest class, which can be used to display a permission prompt to users to confirm the registration of the website as an IdP. The permission request is used when IdentityProvider.register() is called, and the IdP is only registered if the user accepts the permission. Design Doc: https://docs.google.com/document/d/1MKpxTTLi-1e5-0brsdy50TVk2YM9AghoL3diSpRv_vE/edit?tab=t.0 Issue: https://github.com/fedidcg/FedCM/issues/240 Bug: 1406698 Change-Id: I85c260dd6a7f3877d2bc3b4c3ecb8fece1700e92 Low-Coverage-Reason: COVERAGE_UNDERREPORTED This CL adds tests to most LOC that it introduces, sometimes to classes that weren't tested at all, so I think the bot isn't capturing that level of detail. I believe that the LOCs that aren't covered are entries in enums that aren't tested in UI tests. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101281 Reviewed-by: Elias Klim <elklm@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/main@{#1271091}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.