commit | 88574aa1a3aed9924caec756938a6a307e4a006a | [log] [tgz] |
---|---|---|
author | Jered Gray <jegray@google.com> | Wed Jan 23 21:16:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 23 21:16:07 2019 |
tree | a5a975d4047c3402d69603e5f2a102191b489c0b | |
parent | 6447cd5b54e34c1c05c272f64004612d02d4f51b [diff] |
Reland "Fix flakiness in previews browsertests" This reverts commit de34f0bdf289e3b788f7a09be8ae97c45d1e9832. Reason for revert: Fixed additional flakiness Original change's description: > Revert "Fix flakiness in previews browsertests" > > This reverts commit ddd4f721f82a2b4065d214eee99e9fe28199ee15. > > Reason for revert: Looks like some tests become flaky (or even flakier?) > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176 > > Original change's description: > > Fix flakiness in previews browsertests > > > > The previous logic relied upon the hints requested by the store upon a > > navigation to a url being loaded prior to the commit. This was not > > guaranteed to happen when cores were not available on a machine for > > background threads. > > > > The HintCache has been modified so that it now runs the hint loaded > > callback even in the case where no hints are available for the host. > > > > Additionally, a histogram has been added that tracks the loading of > > hints from the hint cache store has in PreviewsOptimizationGuide. The > > tests now run a priming navigation that waits for the hints to be > > loaded. This ensures that the hints are guaranteed to be available > > during the tests. > > > > Bug: 923161 > > Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c > > Reviewed-on: https://chromium-review.googlesource.com/c/1423617 > > Commit-Queue: Jered Gray <jegray@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625056} Change-Id: I675f7a0b3eb79d468100af8775310bb64531b069 Reviewed-on: https://chromium-review.googlesource.com/c/1431019 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625352}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .