commit | 8b110fed0c6b51a23b17a611964d37e7288e89cd | [log] [tgz] |
---|---|---|
author | Gastón Rodríguez <gastonr@microsoft.com> | Wed Sep 10 22:55:44 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 10 22:55:44 2025 |
tree | b5ce56b36d3aa7cacc6640ab31f391f36f2138c4 | |
parent | fec557156edb64cb94aea0a59b774d5690841ed5 [diff] |
Reland "Send dropEffect attribute on drag and drop events" This is a reland of commit 0542983115c4ccbaa2b1dd15faff2675d520bbeb Reason for reland: This CL was erroneously assigned blame for flakiness in some tests Drag and Drop browser tests in chromeos and linux. See bug: https://crbug.com/442927728 Original change's description: > Send dropEffect attribute on drag and drop events > > This CL implements the dropEffect attribute in the dataTransfer property > in drag and drop event to match the spec. > https://html.spec.whatwg.org/multipage/dnd.html > > The attribute is currently not being set, defaulting to "none" on all > events. > > Many existing tests were updated to pass with the new implementation. > Notably, the default dropEffect for some "effectAllowed" attributes has > been changed to match the defaults in the table found in "6.11.4 The > DragEvent interface" in the spec. (defaulting to copy whenever copy is > available, and to link if link is available) > > Bug: 434151262 > Change-Id: Iaeaa7e0e4b9a44e89379b6adf72650ab89fe3dd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6803149 > Commit-Queue: Gaston Rodriguez <gastonr@microsoft.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1509844} Bug: 434151262 Change-Id: Id77db2432864ce8ba8f27b7fd216fd21145791b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6935426 Commit-Queue: Gaston Rodriguez <gastonr@microsoft.com> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1513989}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.