Google Git
Sign in
chromium / chromium / src / 8b11e89fc8de45ea915cf5a5fd300fbce16a783a
commit8b11e89fc8de45ea915cf5a5fd300fbce16a783a[log] [tgz]
authorLei Zhang <thestig@chromium.org>Wed Oct 19 22:31:45 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 19 22:31:45 2022
tree9e48af95cbc62bf572fcc7dbb1276cfc089f8e1c
parentd4a4a0f782a991b1660e447922575bbbe9178669 [diff]
Change sync's ToValueVisitor to use base::Value::Dict internally.

Change ToValueVisitor to hold a base::Value::Dict pointer instead of a
base::DictionaryValue pointer. Update internal uses that dereferences
the pointer. Add an adaptor to the ToValueVisitor user to continue
returning std::unique_ptr<base::DictionaryValue> to the outside world.

Bug: 1187061
Change-Id: Icc8daf64cf47d2f9a3e6a71361233d8a895323a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956659
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/main@{#1061281}
1 file changed
tree: 9e48af95cbc62bf572fcc7dbb1276cfc089f8e1c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.