Google Git
Sign in
chromium / chromium / src / 8b1ea2f8a01fb53a86b51d5837ece2b5f8f45e1c
commit8b1ea2f8a01fb53a86b51d5837ece2b5f8f45e1c[log] [tgz]
authorKen Rockot <rockot@google.com>Thu Feb 23 16:30:13 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 23 16:30:13 2023
tree2f137a02e4da0fe234edff5d126bd9dd00cd330f
parentb4bc8c4ec1b3c4030f7a98dd91a33378c1bf79bf [diff]
Revert "Mojo: No validation failure on client death"

This reverts commit 8b577f6b41f5740b7fad1ebf33c29b9e68457b47.

Reason for revert: New crashes (https://crbug.com/1417393) causing more harm than good. ipcz is on by default anyway for Chromium, so might as well go back to the less-bad validation failure (and dump-without-crashing) behavior for non-Chromium clients.

Original change's description:
> Mojo: No validation failure on client death
>
> If a client process dies during early Mojo handshake, it is
> inadvertently regarded as a validation failure and generates an
> undesirable dump-without-crashing report.
>
> This fixes that.
>
> Fixed: 1394988
> Change-Id: I6931ad23c7cfdf4cc2f916c2795544dacdf12488
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4262692
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/main@{#1106580}

Bug: 1394988
Fixed: 1417393
Change-Id: I1785d302a82aefa197a46e201d8fe3cd27d608a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4287019
Commit-Queue: Ken Rockot <rockot@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1108980}
1 file changed
tree: 2f137a02e4da0fe234edff5d126bd9dd00cd330f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.