Google Git
Sign in
chromium / chromium / src / 8b33582488897106ae2bc7133274448ac7b08e16
commit8b33582488897106ae2bc7133274448ac7b08e16[log] [tgz]
authorWes Okuhara <wesokuhara@google.com>Mon Nov 21 20:00:38 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 21 20:00:38 2022
treee388ade13b9730f1728a9e20ae4ae1f5393b8347
parentf138a5149eece0975ca006acaa420dafff7e853b [diff]
Reland "CrOS Settings: Convert MainPageBehavior to TS"

This is a reland of commit b44466eedaba1628ffa12598d44cfee441916b7c

This initially failed due to Crostini Tast test errors, per b/253910528.
Ensure that it passes the chromeos-eve-chrome CQ bot. See comments
below regarding the root cause for failure.

Test: chromeos-eve-chrome CQ

Original change's description:
> CrOS Settings: Convert MainPageBehavior to TS
>
> Converts MainPageBehavior to TS and upgrades it from a legacy Polymer
> behavior to a mixin. Also applies RouteObserverMixin to the elements
> using MainPageMixin to ensure the correct currentRouteChange() super
> method is called.
>
> about section
>
> Bug: chromium:1315757, chromium:1324103
> Test: Manually test route navigation, page linking, advanced section,
> Change-Id: Ic28bd8e74885b704085c240e8c925ec426512288
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3943835
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: Wes Okuhara <wesokuhara@google.com>
> Cr-Commit-Position: refs/heads/main@{#1059360}

Bug: chromium:1315757, chromium:1324103
Change-Id: I3042883b30b9692438d55b27312ec0fcc517d696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961311
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074206}
8 files changed
tree: e388ade13b9730f1728a9e20ae4ae1f5393b8347
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.