Google Git
Sign in
chromium / chromium / src / 8b71f8b2a9022e877b9a8d7a5692a2746303b810
commit8b71f8b2a9022e877b9a8d7a5692a2746303b810[log] [tgz]
authorJoe Downing <joedow@google.com>Tue Apr 25 17:32:09 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 25 17:32:09 2023
treeedec405af2bb156cd2b1e5f68921a51a032363e7
parentbd9caec306ad7cc3308651a2fcf0c6d70a58540d [diff]
Set target framerate using a Video control message

The current implementation uses SDP format parameters to adjust
the framerate. This works well for VP8 and VP9 but is not the
supported way of adjusting the AV1 framerate and isn't possible
for H.264. Also we've seen that other browsers occasionally
mangle the SDP (or even set their own max-fr values) which further
complicates this logic.

I'd like to have a consistent way to set the target framerate for
the host, one which will work regardless of the currently
selected encoder so my new approach is to use a control message.

I will likely extend this in the future to control the encoder
speed as well though that is not in scope for this CL.

Bug: 217468304
Change-Id: I690420f5af02c5ed11f96bad5a7646cf9eb2cc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4448768
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1135337}
16 files changed
tree: edec405af2bb156cd2b1e5f68921a51a032363e7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.