cros_next: Fix bar animation when jelly is on
This fixes a use-after-free (UAF) bug in the desk mini view removal
animation when it is combined with the bar slide animation. The root
cause of the bug is that when the mini view removal animation is
triggered but not yet finished, and at the same time the bar view is
removed, the mini view animation ends up trying to use a dangling
pointer.
The fix is to add an abort handler to the mini view. This handler will
abort the mini view's ongoing animation if the mini view is removed or
if a new animation is triggered.
It also fixes a bunch of flaky browser tests.
Bug: b/289530755, b/290106345, b/289525498, b/287680276
Test: DesksClientTest.{RecallSavedDesk,SystemUILaunchMultipleDeskTemplates,SaveEmptyDesk,SaveActiveDesk}
Change-Id: Id12829aeae2c3c8af8637ca5f2e47d623d05dc9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4663933
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Daniel Andersson <dandersson@chromium.org>
Commit-Queue: Yongshun Liu <yongshun@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1166719}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.