| commit | 8be71089f737833c5c25fc06c4565055b529f829 | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <dcheng@chromium.org> | Wed Jun 19 17:02:16 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 19 17:02:16 2024 |
| tree | d168cdb8cd249230c9fdbec93433872e55be02fc | |
| parent | 396f34f201afa06c5530d4e0cf12a91c19847352 [diff] |
Remove unneeded iterator decrement in CompositorFrameReportingController This iterator decrement does nothing, since the decrement happens after the original iterator's position is stored into `expired_smooth_thread`. This decrement is actually unsafe, as `lower_bound()` may return `begin()`. Often times, the compiler simply optimizes out the dcerement, and nothing bad happens, but random things that perturb code generation (such as reordering completely unrelated fields) may prevent the decrement from being optimized out (and thus, causing crashes). Bug: 40222690 Change-Id: I35bc8047a1f0631ce871b4579e6cf71958dfaed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640505 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1317086}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.