commit | 8c1ac7175745f8ab10550b6bb44a8aebe346b573 | [log] [tgz] |
---|---|---|
author | Matt Menke <mmenke@chromium.org> | Mon May 23 16:56:50 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 23 16:56:50 2022 |
tree | 8b5742e68ef0aef562a96d7a6405436861a40190 | |
parent | a1138ed441a2b3bfbc55d8c784e2dec9e2caff84 [diff] |
Merge: [FLEDGE] Don't use DataDecoder objects. Instead use DataDecoder::ParseJSONIsolated, which doesn't use an object. DataDecoder appears to be broken, in that is can invoke callbacks passed to it after it is destroyed, which violates its API contract. InterestGroupPermissionsChecker doesn't actually need it. I had been thinking we'd make operations individually cancellable, to better handle having too many headless requests on navigate away, which is why I was using it in the first place. However, I decided a simpler approach would work well enough, so ParseJSONIsolated with a weak pointer works just as well, and possibly with lower overhead. (cherry picked from commit 752bfaf78c826c766b445fb0c8f524f7bdbdb07b) Bug: 1327312 Change-Id: Ie0c22c214e7a818b21c1faae4ae7dbcb47721a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653090 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1005899} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3660902 Auto-Submit: Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#184} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.