Label: Use GetPreferredSize(SizeBounds) in /ash/ambient GetPreferredSize() considers the currently available layout space to be unlimited. However, for some views (eg: label), their preferred size is strongly related to the currently available space, which leads us to need to use GetPreferredSize() + GeHeightForWidth(), which results in two layout calculations. It also resulted in some errors that could not be repaired, eg: 41295639. In the end we chose to use GetPreferredSize(SizeBounds) to solve these problems. There is also the concept of constraint space in Blink LayoutNG. This CL was uploaded by git cl split. R=cowmoo@google.com Bug: 40232718 Change-Id: I926f39c343cf85eca88bb0ed63c88736d8d88be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5426258 Auto-Submit: Weidong Liu <weidongliu@chromium.org> Reviewed-by: Jeffrey Young <cowmoo@google.com> Commit-Queue: Jeffrey Young <cowmoo@google.com> Cr-Commit-Position: refs/heads/main@{#1284160}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.