Google Git
Sign in
chromium / chromium / src / 8cb537b0ec9e2470d34364de2fcb96fd96ed3ac5
commit8cb537b0ec9e2470d34364de2fcb96fd96ed3ac5[log] [tgz]
authorRyan Sultanem <rsult@google.com>Thu Mar 09 14:56:08 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 09 14:56:08 2023
tree06eae50557b35553b4207fccedefc239298f4afa
parent3994c924107384d0e5372a178e85260f78c93e25 [diff]
Reland "[KeyedServiceFactory] Do not allow late initialisation of factories."

This is a reland of commit c0b1dda334f66f72d106f4e7efbfbcc64aba47ba

Original change's description:
> [KeyedServiceFactory] Do not allow late initialisation of factories.
>
> Added a check after the main `EnsureBrowserContextKeyedServiceFactoriesBuilt()` function in chrome/ not to allow late initialisation of KeyedService Factories.
>
> If a late init is happening:
> - DCHECK if DCHECKs are enabled. Otherwise
> - DumpWithoutCrashing in order to get some user cases without crashing their session.
>
> Bug: 1412439
> Change-Id: I38e755016b762b481253df05e94b1f8646278bc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299071
> Commit-Queue: Ryan Sultanem <rsult@google.com>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1114533}

Bug: 1412439
Change-Id: I812d2e1c4ca5741efbb78436ce1f1ba98289e88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4322009
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115121}
3 files changed
tree: 06eae50557b35553b4207fccedefc239298f4afa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.