commit 8cf9eb95193e363760bd4587919df1cacb0fafd9
author Yoichi Osato <yoichio@chromium.org> Mon Oct 21 06:22:33 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 21 06:22:33 2024
tree 5f2321ca59c31719e06d55ee9b7ee215c099507b
parent 7041a26d8de95ebdbc6e726e0c56abb265b5d75d

Revert "media: Report CDM utility process crash exit code"

This reverts commit 98e6bb8ea09d03b99398dc5aa3195b42a929a623.

Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4864110094188544

Original change's description:
> media: Report CDM utility process crash exit code
>
> There is a way to investigate the stability issue on CDM utility
> processes with the existing histograms:
> ```
> ChildProcess.Crashed.UtilityProcessHash
> ChildProcess.Launched.UtilityProcessHash
> ChildProcess.LaunchFailed.UtilityProcessHash
> ChildProcess.Crashed.UtilityProcessExitCode
> ```
>
> However, this requires non-trivial steps to extract the data for the CDM
> specific crashes.
>
> Added new histograms to record the launch result and crash exit code:
> ```
> Stability.Media.Cdm.{CdmUtilityProcessType}.Crash.ExitCode
> Stability.Media.Cdm.{CdmUtilityProcessType}.Launch
> Stability.Media.Cdm.{CdmUtilityProcessType}.Launch.LaunchErrorCode
> Stability.Media.Cdm.{CdmUtilityProcessType}.Launch.Launch.WinLastError
> ```
> where CdmUtilityProcessType = {CdmServiceBroker,
> MediaFoundationServiceBroker, Unknown}.
>
> With the new histograms, we can easily monitor them and track down the
> root cause by exit codes.
>
> Unit tests:
> ```
> autoninja -C out\Default metrics_unittests
> out\Default\metrics_unittests --single-process-tests --gtest_filter=ContentStabilityMetricsProviderTest.*
> ```
>
> Manual tests:
> 1. Causing an access violation error (-1073741819 = 0xC0000005) in
> the CdmServiceBroker.
> ```
> - Histogram: Stability.Media.Cdm.CdmServiceBroker.Crash.ExitCode recorded 1 samples (flags = 0x41) [#]
> -1073741819-O                                                                        (1 = 100.0%)
>
> - Histogram: Stability.Media.Cdm.CdmServiceBroker.Launch recorded 1 samples, mean = 1.0 (flags = 0x41) [#]
> 0  O                                                                         (0 = 0.0%)
> 1  -O                                                                        (1 = 100.0%) {0.0%}
> 2  O                                                                         (0 = 0.0%) {100.0%}
> ```
> 2. Causing an access violation error (-1073741819 = 0xC0000005) in
> the MediaFoundationServiceBroker.
> ```
> - Histogram: Stability.Media.Cdm.MediaFoundationServiceBroker.Crash.ExitCode recorded 1 samples (flags = 0x41) [#]
> -1073741819-O                                                                        (1 = 100.0%)
>
> - Histogram: Stability.Media.Cdm.MediaFoundationServiceBroker.Launch recorded 1 samples, mean = 1.0 (flags = 0x41) [#]
> 0  O                                                                         (0 = 0.0%)
> 1  -O                                                                        (1 = 100.0%) {0.0%}
> 2  O                                                                         (0 = 0.0%) {100.0%}
> ```
>
> Bug: b:368672525
> Change-Id: I327ede039d16b2d4d2a7f12a055e05636a4ad54a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5932764
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Sangbaek Park <sangbaekpark@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1370834}

Bug: b:368672525
Change-Id: I068a9e77e83beffc6f0b22e3249dae559e9d6d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938573
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Owners-Override: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1371197}