Google GitGoogle Git
Sign in
chromium/chromium/src/8d44f46db31a8669c6d79b5dca050522183f61f8
commit
8d44f46db31a8669c6d79b5dca050522183f61f8
[log]
author
Michael Tatarski <mtatarski@google.com>
Mon Jul 14 14:50:28 2025
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Jul 14 14:50:28 2025
tree
b0640ba1ede49e1a2b848dfeb56f05f813638a57
parent
791384c8331dd6974aaf9b58e6847e68b8e89be1 [diff]
Add `last_visit` to bookmark importer

This CL adds support for importing the `last_visit` field from bookmark
files.

- A new optional field `last_visit_date` is added to `ImportedBookmarkEntry`.
- The `ContentBookmarkParser` is updated to parse the `LAST_VISIT` attribute from bookmark files.
- Unit tests are updated to verify the new behavior for bookmarks both with and without a specified last visit time.

Bug: 430236400
Change-Id: If6cc5e8912887540544e6311f1b030cd45f78f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6718750
Auto-Submit: Michael Tatarski <mtatarski@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1486299}
4 files changed
tree: b0640ba1ede49e1a2b848dfeb56f05f813638a57
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.