Revert "[webauthn] Update dialog focus behaviour"

This reverts commit b03aa6bffded0c7769eb5000db1642d78bc24ec6.

Reason for revert: breaks keyboard navigation on linux.

Second attempt at reverting this CL.

Original change's description:
> [webauthn] Update dialog focus behaviour
>
> This CL updates the focus behaviour of webauthn dialogs. Previously, the
> "primary" control of each sheet was focused, which was either a list of
> options or one of the buttons. This behaviour was problematic for screen
> readers:
>
> First, it is not recommended to jump to a button that is most likely not
> what the user wants to do at a given moment [1]. E.g. on the security
> key activation dialog, the user most likely wants to tap their security
> key, not cancel out of the dialog.
>
> Second, the authenticator dialog is special because its contents change
> as the user interacts with the authenticator, but the container itself
> does not. The resulting behaviour is that screen readers will read
> whatever gets focused next but will not announce the new context. This
> is really confusing, e.g. if the request times out, VoiceOver on Mac
> would announce "Cancel - Button" instead of "The request timed out...".
>
> This CL addresses these issues by making the title of the dialog
> accessibility-focusable and focusing it every time the sheet is updated.
> The modal is still keyboard navigable, with the enter key triggering the
> default button if present.
>
> [1] https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/
>
> Bug: 1347607
> Change-Id: If59fbd8f2dbfa3eb7a554d6ecd5ad82df29f2879
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4894369
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Commit-Queue: Adam Langley <agl@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1202832}

Bug: 1347607
Change-Id: If2019823cf1de1b770f06fa0028aa7ef791d98e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4902478
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1203626}
19 files changed
tree: 1916ede6d3e009581aebd2ccaa77d7d7d2af7221
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.