Google Git
Sign in
chromium / chromium / src / 8d8268b8de8d26bbd857db48f702029d681282e5
commit8d8268b8de8d26bbd857db48f702029d681282e5[log] [tgz]
authorTsuyoshi Horo <horo@chromium.org>Thu Jul 24 23:53:14 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 24 23:53:14 2025
tree7ecf9ff9b9ae3797fe0d87775663bf127536f65c
parentd50a738cde9d1d8fdc2d64eb43e469194c9163fe [diff]
disk_cache: Hardcode 'doomed' status in SQL queries

This change refactors the SQL queries in SqlPersistentStore to hardcode
the doomed status (0 for live, 1 for doomed) directly into the query
strings, rather than passing it as a bind parameter.

As part of this change:
- SQL query constants and the Query enum have been renamed for clarity
  (e.g., kOpenEntry_SelectResources -> kOpenEntry_SelectLiveResources).
- C++ code using these queries has been updated to remove the
  now-unnecessary BindBool() calls for the doomed parameter.

Bug: 422065015
Change-Id: I7d97ee0f228e6a7e9375ec5085e7fcc9f7500d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780860
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491757}
3 files changed
tree: 7ecf9ff9b9ae3797fe0d87775663bf127536f65c
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. clusterfuzz-data
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.