Google Git
Sign in
chromium / chromium / src / 8dc65fd6c8b30b8237fc62b0d08790ba6ee0b0b9
commit8dc65fd6c8b30b8237fc62b0d08790ba6ee0b0b9[log] [tgz]
authorDibyajyoti Pal <dibyapal@chromium.org>Mon Mar 24 15:49:01 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 24 15:49:01 2025
treec489d7df423e64b02150219944cca60de3ac8769
parent427f9ba4e82aeb41267ab1e8d784c97c367e0798 [diff]
Revert "[PWA] Move home tab handling code to NavigationCapturingProcess"

This reverts commit 032451d6a3cc75d416406527784c3a7e5b2e4951.

Reason for revert: Capturing navigations in existing tabs in  ::Navigate/NavigationCapturingProcess when they are not exclusively initiated by WebContentsImpl::CreateNewWindow() is currently not supported, making this migration more complicated than usual.

This change will be reverted for the time being, and handled in the future in a follow-up after all the correct rewiring has been done.

Original change's description:
> [PWA] Move home tab handling code to NavigationCapturingProcess
>
> Since navigation capturing v2 on CrOS currently handles tabbed PWAs, the
> home tab handling logic from inside browser_navigator.cc has been moved
> to the NavigationCapturingProcess, while maintaining the same behavior
> of navigation happening in the current tab.
>
> This is done by:
> 1. Ensuring the NavigationCapturingProcess gets created
> on ChromeOS for PWAs with a home tab url.
> 2. Maintaining the same behavior by returning the current browser that is populated in the NavigateParams with the activated tab so that navigation happens there.
>
> Tested by running the WebAppTabStripBrowserTest tests that were failing
> in PS1.
>
> Bug: 392950568
> Change-Id: Ib8605bbe7879fc99df7c9ac6b417bd9e3687b4da
> Include-Ci-Only-Tests: chromium.mac:mac14-tests|browser_tests
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6353116
> Reviewed-by: Mike Wasserman <msw@chromium.org>
> Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1433633}

Bug: 392950568
Change-Id: I145a3a80a976d735ccc0539a4ad1d872e397c531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6383336
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436875}
2 files changed
tree: c489d7df423e64b02150219944cca60de3ac8769
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.