[EditContext] Check whether frame exists in SetSelection EditContext.updateSelection can be called even when the EditContext is in a detached frame, causing a crash because SetSelection assumes that DomWindow()->GetFrame() is always non-null. Fix the crash by adding a null-check. Note that EditContext has other usages of DomWindow()->GetFrame() that are not protected by a null-check. As far as I can tell these other usages should not occur in a detached frame. If however we start seeing crashes around these other usages, we should consider protecting all of them with similar checks. Bug: 356211970 Change-Id: I586be30f820ee8470f5d3f5c8c1c5731ca14e558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5761754 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1337926}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.