commit 8de5119eeaeded4dc307043468ebfaac58263023
author Colin Blundell <blundell@chromium.org> Wed Feb 19 09:06:59 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 19 09:06:59 2025
tree de8aef04c5d150b96eb4de32cdc6df76b04ea80c
parent 9bdea5ea6c124ea9ba50f30776b5ff225eb376db

[//cc] Have BitmapRBP create software SI with resource's format

This CL changes BitmapRasterBufferProvider to create its software
SharedImages with the InUsePoolResource's format rather than hardcoding
BGRA. In practice this is guaranteed to be BGRA:

* GetFormat() returns BGRA [1]
* TileManager uses GetFormat() to compute the format to use when
  creating InUsePoolResource instances [2][3][4]
* TileManager will update the format from the above computation only if
  the color space in the target color params is HDR [5]. Here it will
  not be as the target params come from here [6] and LayerTreeHostImpl
  uses SRGB when the software compositor is being used [7].

[1] https://source.chromium.org/chromium/chromium/src/+/main:cc/raster/bitmap_raster_buffer_provider.cc;l=125-127;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:cc/tiles/tile_manager.cc;l=1400;drc=3b0638107e9b1466362547e6478a54f9c66994b5
[3] https://source.chromium.org/chromium/chromium/src/+/main:cc/tiles/tile_manager.cc;l=1441-1443;drc=3b0638107e9b1466362547e6478a54f9c66994b5
[4]
https://source.chromium.org/chromium/chromium/src/+/main:cc/tiles/tile_manager.cc;l=1979-1981;drc=3b0638107e9b1466362547e6478a54f9c66994b5
[5] https://source.chromium.org/chromium/chromium/src/+/main:cc/tiles/tile_manager.cc;l=1401-1405;drc=3b0638107e9b1466362547e6478a54f9c66994b5;bpv=1;bpt=1
[6] https://source.chromium.org/chromium/chromium/src/+/main:cc/tiles/tile_manager.cc;l=941-942;drc=3b0638107e9b1466362547e6478a54f9c66994b5
[7] https://source.chromium.org/chromium/chromium/src/+/main:cc/trees/layer_tree_host_impl.cc;l=2004-2009;drc=3b0638107e9b1466362547e6478a54f9c66994b5

Bug: 40064122
Change-Id: I723eb6b5f49f2eead50d5454dd9a2c895c801d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6276384
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421818}