| commit | 8ded714d76158661550f2075af7693ee4f7333bd | [log] [tgz] |
|---|---|---|
| author | Florian Leimgruber <fleimgruber@google.com> | Tue Oct 22 10:16:22 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 22 10:16:22 2024 |
| tree | edd27a38fe51d8d3aeb88d6a49a09f8db510e175 | |
| parent | 9b4f89063616ab750313859fa2946f14cf0c14c7 [diff] |
Clean up shared label logic Note that all this code is behind a feature flag. This CL is in an effort to get the code ready for another rollout attempt. No behavior changes - purely cosmetic code clean ups: - Using iterators instead of indices. - Using ranges algorithms instead of loops. - Simplifying the interface by returning a std::vector<std::u16string_view> instead of a std::optional<std::vector<std::u16string>>. Due to the string_view and move semantics, we actually save a copy in the process. - Removing/rewriting some state-the-obvious comments. - Using gMock matchers in tests. Demo: https://screencast.googleplex.com/cast/NTc1NjE4MDI5NDAwODgzMnxlMmQ0OTQxZC1jZg Bug: 320965828, 40100455 Change-Id: Ibc85dc0bd7b6920518789da722220b6b2430c68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938884 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1371934}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.