commit | 8e397e6338b7ed3bdf4f2c47412302e1c280a387 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Mar 26 17:13:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 26 17:13:20 2019 |
tree | dd12e4e58ae35b7d3495c11d68c5662a40c5c7cc | |
parent | 96e024f974bc66451474f65e35e55e433e3457ba [diff] |
Fixing dependency problem for the mojo Range class The mojo Range class needs range_struct_traits.h and the build system wasn't setup to allow that. Simplest for everyone is to integrate the struct_traits target into the mojom target and let the mojo system figure out dependencies. This made everything simpler. Without this fix you got errors like the one below: ERROR at //out/Default/gen/content/common/input/input_handler.mojom-test-utils.cc:49:11: Can't include this header from here. ^-------------------------------------- The target: //content/common:mojo_bindings is including a file from the target: //ui/gfx/range/mojo:struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //content/common:mojo_bindings --> //services/ws/public/mojom/ime:ime --[private]--> //ui/gfx/range/mojo:struct_traits Bug: 938893 Change-Id: If01554d38ca3d5f4280d32c658d1f7044f14c29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536056 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644390}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .