commit | 8e73a24ed999094528eca5c162644cab3203b840 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Wed May 08 15:57:19 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 08 15:57:19 2024 |
tree | 5e1d11f9de4490317fc9825d7e5b0da7f2dd76da | |
parent | 8fd8839add8ddcc1bd8840ed0c821a2259529248 [diff] |
Reapply "[layout] Enable block layout buttons." This reverts commit f97fd9eae16c3aa3a08ec983e9fff00b7e3d7bb9. This additionally adjusts the flakey test: third_party/blink/web_tests/fast/forms/color/color-picker-top-left-selection-position-after-reopen.html To include some margin. The test non-deterministically inserts a 2-line button next to the <input type=color>. The with the flag enabled pushed the color input down (as baseline alignment is now different), and would then get removed, making the chooser seem to be placed incorrectly. The additional margin prevents this shift from occurring. Original change's description: > [layout] Enable block layout buttons. > > This enables block layout buttons by default. > > This fixes two WPT tests: > html/rendering/widgets/button-layout/anonymous-button-content-box.html > html/rendering/widgets/button-layout/inline-level.html > > The control-clip rebaseline is due to the content not painting > atomically anymore (vs. flex-items which do). > > Bug: 41458734, 40937312 > Change-Id: I4668cf7cecd4fa79a73c0683bdcac9b79bd2ade1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494533 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1294308} Bug: 41458734, 40937312, 338299516 Change-Id: I54b687ad0842feadd0901ab3f4b705897537b363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5524034 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298138}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.