Google Git
Sign in
chromium / chromium / src / 8e820cfac53f56acb5af979230660eebdb6ff046
commit8e820cfac53f56acb5af979230660eebdb6ff046[log] [tgz]
authorchinsenj <chinsenj@chromium.org>Sat Nov 20 02:14:23 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Nov 20 02:14:23 2021
tree40dde78ee2c1acd44858178bab05d3223c9839e1
parent36c7e5e44f04128b21757f26301e2b5fc2e1deeb [diff]
desk_templates: Separate unsupported app type from supported window api

Currently the `IsWindowSupportedForDeskTemplate()` api used to
determine whether an app is supported returns false if the window has
no associated Full Restore app id. However, just because a window lacks
this doesn't make the app unsupported.

This CL moves the check for a Full Restore app id to
`CaptureActiveDeskAsTemplate()`, omitting the respective window from
the template if it lacks an app id.

Test: added
Bug: 1269466
Change-Id: Ie1fd858a8f22db81a63b3b9740d7fbb9827baef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288771
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#943784}
6 files changed
tree: 40dde78ee2c1acd44858178bab05d3223c9839e1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.