commit | 8ee984b428def8ffbddd7c81aa93f209b8c3f762 | [log] [tgz] |
---|---|---|
author | Siddhartha S <ssid@chromium.org> | Fri Apr 25 23:39:21 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 25 23:39:21 2025 |
tree | 2142600308cb2b9ea34e0ae6209f6852d615e6c1 | |
parent | c92bd933e8d0bc946d75b4bbe75d7bbdb640d9b8 [diff] |
Revert "[Message Sync] Update last seen timestamp when clearing dots locally" This reverts commit f9e74d17daf8b7a4140bfa6d7c97cf1e3074a3b8. Reason for revert: causes crash in Canary crash/df3ff51bff579835 stack trace: https://paste.googleplex.com/5461656207097856 Bug: 397767033, 413768466 Original change's description: > [Message Sync] Update last seen timestamp when clearing dots locally > > Currently when tab dots are cleared via another entry point such > as clicking X on collaboration message card on mobile, we clear > the tab dots, but it doesn't get sent over to sync. In this CL, > we do that by updating the last seen timestamp. > A public method was added to TabGroupSyncService for this purpose > that can be invoked from UI callsites. > > Bug: 397767033 > Change-Id: If43eacc77472d73d518a3007eef60db225814ece > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6486268 > Reviewed-by: Mickey Burks <mickeyburks@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1451415} Bug: 397767033 Change-Id: Ie8fe102f67e16d661b7000a58460b829cd02ce6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6492596 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Darryl James <dljames@chromium.org> Cr-Commit-Position: refs/heads/main@{#1452122}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.