commit 8f353252f763c25e21306139e72d98b14dc8109d
author Benjamin Williams <bwwilliams@google.com> Thu Oct 17 14:24:48 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 17 14:24:48 2024
tree f466d47b772b1b239c0e5e532b6f9364a6bd3f23
parent 79973d79c563bb056507f4b0a5ccd2e570f6a8c5

Make Address Bar Position tip phone-only

This CL updates the address bar position tip to check if the device form
factor is a phone before displaying.

The address bar selection feature is currently only available on
iPhones, so this change ensures the tip is not shown on other device
form factors, e.g., iPads, where the feature is not supported.

This is done by:

* Adding a new constant `kIsPhoneFormFactor` to represent the device
  form factor signal.

* Updating `kTipRequiredSignals` to include `kIsPhoneFormFactor` as a
  requirement for the address bar position tip.

* Modifying the corresponding query generation logic to include
  `kIsPhoneFormFactor`.

* Adding a new test to verify that the tip is not displayed when the
  device is not a phone.

Low-Coverage-Reason: COVERAGE_UNDERREPORTED

Fixed: 374063027
Change-Id: I9985bc9dc267febf2e7fdb93e8bc9be0c822746b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938750
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1369990}