Google Git
Sign in
chromium / chromium / src / 8f94358b26ba6caf99b576547b1c49b759637b49
commit8f94358b26ba6caf99b576547b1c49b759637b49[log] [tgz]
authorScott Violet <sky@chromium.org>Thu Sep 30 00:36:36 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 30 00:36:36 2021
treeee0bef7cbcc7b46d4164c830f28b0b8c9ff2cb0a
parentf666e640b48549eeccbff46b7de37e899cacc6ae [diff]
Revert "Fix Event to copy target"

This reverts commit a65ab09ec03e490efe4896b03af8a2bcfb4f7d81
as it causes a use-after-free. The issue is some code keeps around
Events. Code that does this makes a copy, and expects the Event to
be valid. By allowing the target to be copied makes it all to easy
to get a use-after-free if the EventTarget is used from the Event.

Also note that I had to remove an assertion in a drag and drop test
that was added after the original patch landed.

Bug: 1253238
TEST: none
Change-Id: Ib304e8d4d63162987ddd7cb5776d916bce5af9a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193882
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926563}
3 files changed
tree: ee0bef7cbcc7b46d4164c830f28b0b8c9ff2cb0a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.