Fix dangling ptr by introducing viz::TracedValue::Id

viz::TracedValue::AppendIDRef and SetIdRef took a void* for the ID.
Sometimes users of these APIs, such as RasterTaskImpl, would store void*
for use to provide to those APIs. An example of this is the
tile_tracing_id_ field in RasterTaskImpl, which has raw_ptr to a Tile
object for tracing purposes. This specific instance was identified as a
dangling ptr.

For this instance, during tests such as the
CommitToPendingTreeLayerTreeHostImplTest tests, the pointer become
dangling during the destruction of LayerTreeHostImpl. The d'tor would
call ReleaseLayerTreeFrameSink(), calling ReleaseResources() and causing
PictureLayerTiling destruction. The tiling's destruction would trigger
Tile objects destruction during TileManager::FinishTasksandCleanUp().
Doing so leaves RasterTaskImpl::tile_tracing_id_ referencing Tile
objects that no longer exist, triggering a dangling ptr error in
RasterTaskImpl's d'tor.

Rather than fix this via a RAW_POINTER_EXCLUSION, as the pointer is only
used as an ID for viz::TracedValue, this change introduces
viz::TracedValue::Id for use specifying an ID to calls into TracedValue.
Internally, this is just a uintptr_t with a convenience c'tor that
converts from void*. Callers that previously held onto a void* instead
store one of these new Id instances, avoiding dangling ptr concerns.
This change also modifies the signatures, and call sites, of the
TracedValue methods to use the new Id type instead of void*.

Low-Coverage-Reason: OTHER behind disabled by default tracing
Bug: 40212619
Change-Id: I3bb4e8a9e0f799d78be5fdda5da880a04fa48c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6700324
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1484382}
18 files changed
tree: 3e9b9173a04490d0e65cbf65ed380adfb486e614
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .cursorignore
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.