commit | 8fb5482472064e85e8289e6267be7ec69c792034 | [log] [tgz] |
---|---|---|
author | cassycc <cassycc@google.com> | Wed Mar 13 05:27:14 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 13 05:27:14 2024 |
tree | 75ce23130aa4ce0850a44c85ed57b554b4317f63 | |
parent | dc5507234ad5101bf647590e44f5f62706e6bd0c [diff] |
[Office upload] Handle when the upload flow fails from a non-Office file If a non-Office file is renamed to have an Office file extension, the user can initiate the upload flow to try to move it and open it with Google Docs. Although the move to Google Drive is successful, it cannot be opened with Google Docs. This case is detected when: - The alternate URL host is "drive.google.com". - The mime type is not an Office mime type. Show a new error message "File is not a valid document" in this case. https://screenshot.googleplex.com/AzhUBwFospBdw58.png Introduce new enum OfficeFilesUploadResult::kFileNotAnOfficeFile to record this metric. Introduce new helper functions: - IsOfficeFileMimeType() - GetNotAValidDocumentErrorMessage() Bug: b/322909593 b/323452926 Change-Id: Ic1395ff6c86bd3c92c39c9cf734f47fc9bf0438d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5347997 Commit-Queue: Cassy Chun-Crogan <cassycc@google.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1271992}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.