Google Git
Sign in
chromium / chromium / src / 9068f363003009f840b84f36c12551041dcb702e
commit9068f363003009f840b84f36c12551041dcb702e[log] [tgz]
authorAnupam Snigdha <snianu@microsoft.com>Mon Feb 22 19:42:12 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 22 19:42:12 2021
tree8d44e4d7357b38dbda79555234146926ffd3b41d
parentf5606f6187f9a61af5c55b108e8ac7192b00a01c [diff]
Report the actual bounds of the TextField to TSF.

Previously we just used to report the entire app window's bounds to
Windows text input service(TSF) as a hack because we weren't aware
of any API that would give us the actual control bounds of the edit
control when focus is in the Omnibox.
In this patch we are calling |GetContentsBounds| API to fetch the
control bound of the view and convert it into screen coordinates
when TSF queries for the layout bounds.

Bug: 1180381
Change-Id: Ia8fdbe8849aa28ac07f254896d85b606a2dc6f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2708745
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#856380}
1 file changed
tree: 8d44e4d7357b38dbda79555234146926ffd3b41d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.