commit | 908a70c91350595300c3fb6982d60368fd899470 | [log] [tgz] |
---|---|---|
author | Vadym Doroshenko <dvadym@chromium.org> | Wed Feb 06 14:29:08 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 06 14:29:08 2019 |
tree | 60c96459b91e0ded460d904901b70fc1a35eab02 | |
parent | 3c7ebf62ea224d3183b17fc3e269cc06f526087f [diff] |
Fix NavigationHandleImpl::HasUserGesture. CL https://chromium-review.googlesource.com/c/chromium/src/+/1422003 made changes in NavigationHandleImpl::HasUserGesture(), namely has_user_gestture is not updated on DidCommitNavigation. This CL implements setting has_user_gesture in RenderFrameHostImpl::DidCommitNavigationInternal. It basically returns the previous logic. The current calculation of HasUserGesture is the reason of failure tests on CL https://chromium-review.googlesource.com/c/chromium/src/+/1451999. Namely HasUserGesture() returns true in cases, when it should be false. Example: In test PasswordManagerBrowserTest.PromptForXHRSubmit navigation is done with clicking Submit() button with JavaScript, thus GetUserGesture() should return false. Bug: None Change-Id: Ibff0ec78267e9bace58f49b35818235dc2cd872d Reviewed-on: https://chromium-review.googlesource.com/c/1455957 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#629567}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .