webid: inline ECSignatureCreator::DecodeSignature This method does not really belong on ECSignatureCreator - it parses a DER-encoded ECDSA signature (whether it came from ECSignatureCreator or not) then turns it into a packed vector of (r, s) from the signature. It's also only used in the JWT signer code in webid. Since ECSignatureCreator is deprecated anyway, this change removes DecodeSignature altogether and moves its body into the webid code. As part of that, the function (now named UnpackDERSignature) is now free to assume that the signature is valid (since it just created the signature itself) and to assume that r and s are well-formed (for the same reason), so some error paths are converted to CHECKs. Bug: 372283556 Change-Id: I0023795173b28bbe565150ccd37fb7f9a61b8ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6635283 Reviewed-by: Nicolás Peña <npm@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1474540}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.