commit | 91484d7d9339d77f8031f1528d52fe3417ea2b9a | [log] [tgz] |
---|---|---|
author | Sam Davis Omekara <samomekarajr@microsoft.com> | Tue Jun 04 22:45:56 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 04 22:45:56 2024 |
tree | 459f92a31eed9a61919508bb2e2b8710cc7d1785 | |
parent | f31152cbab15455446b75aa6425eca559a63015f [diff] |
Fix the HighlightText and Highlight for CSS system colors This CL addresses the issue where CSS Highlight color and HighlightText color do not match the selection color and selection text color, respectively. The issue was caused as a result of moving the retrieval of system colors in Blink to the color pipeline. To resolve this, this CL makes the following adjustments: A.) The default color for the `kColorCssSystemHighlight` color id now corresponds to a different shade of blue, matching the color defined for `blink::kDefaultActiveSelectionBgColor`. B.) For Mac, the `kColorCssSystemHighlightText` color id is set to black. In dark mode, we blend the system highlight colors to match the approach used for selection color. As a result, the highlight and selection colors are now consistent, addressing the failing wpt: css/css-color/system-color-hightlights-vs-getSelection-001.html. Bug: 336152476 Change-Id: Ia13bc244a7babd88eb3994e83df61b9b60904faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5585347 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Sam Davis Omekara <samomekarajr@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1310272}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.