commit | 9151f87dfbf2f92e5b5549b4eca88a67b70bd1a5 | [log] [tgz] |
---|---|---|
author | Richard Zhang <richardzh@chromium.org> | Fri Dec 09 20:08:52 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 09 20:08:52 2022 |
tree | f544abb43da8d2bd212a454fe20cd8fcd5a85782 | |
parent | d6237902139322452cbbf5b68c4812802bc7b5fd [diff] |
Link ServiceWorkerVersion in-flight requests to event queue idle timeout ServiceWorkerVersion in-flight requests can block idle timeout request from event queue. However they couldn't extend the idle timer. As a result extension service worker events, which leverage in-flight requests, cannot guarantee 30 seconds idle time. In this CL we reuse the idle timeout callback logics in ServiceWorkerEventQueue. That is, 1) cancel the idle timeout when starting an event; 2) check event queue when finished an event, schedule the idle timeout if the event queue is empty. Before checking event queue we also check if there is any in-flight requests. This makes sure idle timeout is scheduled only when in-flight request queue is empty too. ServiceWorkerEventQueue logic remain unchanged. There might be a case that idle timeout is scheduled when there are ongoing in-flight requests. Which is okay because ongoing in-flight requests will block termination request. And by the time in-flight request finishes the idle timeout may be rescheduled. R=lazyboy@chromium.org, rdevlin.cronin@chromium.org Change-Id: I901727d70d1130d0c55fe38f38e507fdc91c4304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022172 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Richard Zhang <richardzh@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1081592}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.