Google Git
Sign in
chromium / chromium / src / 91a6bcf138dd2420b50e379631061f32e78b2ed8
commit91a6bcf138dd2420b50e379631061f32e78b2ed8[log] [tgz]
authorGuido Urdaneta <guidou@chromium.org>Fri Jan 19 16:53:39 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 19 16:53:39 2024
treeba53075136ccb8509510185834b78f1892a352c9
parentb9fa9bb187399c227dcd74d5803f8fa02d0e1d72 [diff]
[BreakoutBox] Do not require a sink signal to do eager conversion

MediaStreamVideoTrackUnderlyingSink tries to convert RGB frames to NV12
if it has observed a signal from sinks requesting GMB-backed frames.
In practice, this occurs when a WebRTC sink wants to use hardware
encoding.

We have observed that the signal usually arrives after some RGB frames
have been sent to the sink and it has fallen back to software encoding,
making the conversions useless.

This CL:
* Enables the conversion without waiting for the signal, similar to
how canvas capture does it.
* Adds a kill switch for enabling conversion without signal.
* Makes getting the GMB manager synchronous, even if running outside
  the main thread.
* Rewrites the condition for eager format conversion so that it is
  easier to read.

Bug: 1519558
Change-Id: Idc953d9569f2252615a3b9ea99a8f0171db0bf31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5216848
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#1249379}
2 files changed
tree: ba53075136ccb8509510185834b78f1892a352c9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.