commit | 91f76a629c7ef110a9eb8f0101e8718fb81e3a1f | [log] [tgz] |
---|---|---|
author | Eric Sum <esum@google.com> | Thu Jun 27 20:13:10 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 27 20:13:10 2024 |
tree | 961044dab12f684a55f02e802f6a72d783d8b976 | |
parent | 6ddcae5705924280c73384880b42f0b8d82c1dc7 [diff] |
Condense multiple occlusion change notifications into 1 re-mirror. This fix is actually not strictly necessary after https://crrev.com/c/5659468, but it's a good thing to do to fortify the code if there's another hidden case like this. If the WindowOcclusionTracker should detect lots of occlusion changes in one pass, it sends a bunch of observer notifications in one loop on the main thread: https://screenshot.googleplex.com/8sfxQqgmNQxskJQ.png The current code leads to a bunch of RecreateDeskContentsMirrorLayers() calls: https://screenshot.googleplex.com/4TXZ9LDSK2Ytsoi.png This is unnecessary and very expensive. All that's needed is one RecreateDeskContentsMirrorLayers() that will capture all of the occlusion changes in one mirroring tree re-build. As stated above, it should be very unusual to see so many occlusion changes in a desk while the desk bar is active, but this weakness is being addressed if there's a case we're not thinking of. Bug: b:294094124 Change-Id: Ia91cb1122774464af381811766c2b43caee2d4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5660285 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Eric Sum <esum@google.com> Cr-Commit-Position: refs/heads/main@{#1320587}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.