commit | 9226624d23acd6156b725e8fdc7f325ee9ddf027 | [log] [tgz] |
---|---|---|
author | Peter Kotwicz <pkotwicz@chromium.org> | Wed Feb 13 14:18:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 13 14:18:01 2019 |
tree | 7a78eb270ab8520dbd925a8cbab642ca8bd4230f | |
parent | 7294879363931a100377353ca3951c9a61f0c4a0 [diff] |
[Android WebAPK] Don't request WebAPK update if WebApkActivity is finished Previously, if a WebAPK needs to be updated because the WebAPK code is out of date, but the user dismisses the WebAPK prior to the Web Manifest being fetched: 1) WebApkUpdateManager#destroy() would cancel WebApkUpdateDataFetcher AND 2) WebApkUpdateManager would not cancel the WebApkUpdateDataFetcher timeout callback. This would cause Chrome to do an update but with the old Web Manifest data. This CL changes WebApkUpdateManager#destroy() to cancel the WebApkUpdateDataFetcher timeout callback BUG=None TEST=WebApkUpdateManagerTest.testDontRequestUpdateAfterManagerDestroyed Change-Id: I216d30ffbd80cdffe77c952ab610e294e4c6a6b8 Reviewed-on: https://chromium-review.googlesource.com/c/1468583 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#631682}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .