| commit | 9241d44ade2adf6d90c21e95a232e4f9ec8b67e3 | [log] [tgz] |
|---|---|---|
| author | François Doray <fdoray@chromium.org> | Mon Jul 22 18:22:29 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 22 18:22:29 2024 |
| tree | 861f4cf72fe946f1929472cb9d4304682591feb8 | |
| parent | 4118ec5f108be8cf5699502e4a4e0a68c9e31127 [diff] |
[content] Check that no frame host is associated with a process host being deleted. ~RenderFrameHostImpl accesses its RenderProcessHostImpl [1], which implies that it must be deleted first. //components/performance_manager makes the same assumption about deletion order [2] and can suffer a use-after-free if it doesn't hold. This CL adds a CHECK to transform the use-after-free into a clear error. [1] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/render_frame_host_impl.cc;l=2011;drc=7fd6b020533024dda8d4c6234dbbba83fd350adf [2] https://source.chromium.org/chromium/chromium/src/+/main:components/performance_manager/graph/frame_node_impl.cc;l=626;drc=0118368addc69722bcff63a8549cd1cdf6e30b77 Bug: 349883130 Change-Id: I4d7941b4c0989de15ee02dfb6e72e442623f55b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5714688 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Auto-Submit: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#1331205}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.