Google Git
Sign in
chromium / chromium / src / 925810b9bd09b097f3f9add6976463da712d429c
commit925810b9bd09b097f3f9add6976463da712d429c[log] [tgz]
authorColin Blundell <blundell@chromium.org>Wed Jan 08 16:18:58 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 08 16:18:58 2025
tree0729d4819bf29802e278aa2800b83331f14294e8
parent8f1a6b7d4449491c9a567c348b714acde4c139e1 [diff]
[Blink] Have CanvasResourceSharedBitmap::Bitmap use RasterFromPixmapCopy

This CL changes CanvasResourceSharedBitmap::Bitmap() to use
RasterFromPixmapCopy(), as the unaccelerated codepath in
CanvasResourceSharedImage::Bitmap() does [1], rather than
RasterFromPixmap(). This is part of the preparation for folding
CanvasResourceSharedBitmap into CanvasResourceSharedImage.

This is a slight behavioral change as we now copy the data when creating
the UnacceleratedStaticBitmapImage rather than referencing the
underlying data directly and holding onto the CanvasResourceSharedBitmap
until the UnacceleratedStaticBitmapImage is released. The behavioral
change should be benign.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource.cc;l=598-613?q=CanvasResourceSharedImage::Bitmap&ss=chromium

Bug: 379996128
Change-Id: I0da02cc57f70b56e8fca09207860dd001c354c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138589
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1403576}
1 file changed
tree: 0729d4819bf29802e278aa2800b83331f14294e8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.