Add SendValidation tag/attribute to Mojo
This change adds a new mojo tag/attribute to make it easier to debug
validation errors on serialization in the case where there's developer
error. This takes advantage of the mojo Feature infrastructure to flip
the validation error on when the feature is on.
```
The tag can be added like so:
feature kBarValidationFeature {
const string name = "BarValidationFeature";
const bool default_state = true;
};
interface Foo {
[SendValidation=kBarValidationFeature]
Bar(Struct struct_needing_validation);
};
```
This change adds unit tests in mojo_unittests.
As a part of this change, another set of serialization templates were
added to facilitate a smaller binary size. If SendValidation is
requested, the alternative template is used. If no SendValidation
specialization exists, then the code will automatically fall back to the
original serialization.
The compile size is greatly expanded because this adds a
new serialization path to every Struct, Union, Array, and Map used by
Mojo. A follow-up change reduces increase down to about 0.45% compile
size increase with additional complexity.
Compile-size: See commit description.
Bug: 400895804
Change-Id: Idb0c4daeb179e938ea4c9e195f6c95f0e45c8f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6328899
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Emily Andrews <emiled@microsoft.com>
Reviewed-by: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1457638}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.