commit | cc50f6659308fc734103026813da970756724681 | [log] [tgz] |
---|---|---|
author | Pranjal Jumde <pranjal@brave.com> | Thu Jan 17 19:41:30 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 17 19:41:30 2019 |
tree | 969f55f6d2b8eac093eb44e54d03ac610839a152 | |
parent | 99a849cd6b59954802be5a72c417027714ab9a9e [diff] |
Fix ScopedBlockingCall DCHECK when analyzing DMG files. file_analyzer.cc opens dmg on the UI thread which disallows blocking leading to a DCHECK failure on debug builds. Test: 1. Open chromium (debug) 2. Navigate to https://github.com/MagerValp/AutoDMG/releases/download/v1.9/AutoDMG-1.9.dmg 3. No crash Bug: 921148 Change-Id: Idb3a06d747a61ed5f92c5f3be92d791877dcd3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1414131 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#623804}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .