commit 9338545878abd6fd9a7509d5365d57f7dbb46231
author Maksim Ivanov <emaxx@chromium.org> Mon Jul 26 20:36:10 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 26 20:36:10 2021
tree 49fe93182d3cbdcf46bef05376b836561133ef86
parent 1a20c448081ff2e949507ba3e9655ac8335a3771

Fix error swallowing in cert provider tests

Fix the issue that the results of some of assertions
were actually ignored in the API tests of
chrome.certificateProvider.

The issue is that assertions on the JS side don't
automatically abort the C++ test - instead, they just
raise a JS exception and send a notification to the C++
side (see the chrome.test.notifyFail() method). When
there's an active ResultCatcher object, such
notifications are observed by it and transformed into
the C++ test failures. However, in the cert provider
tests, due to the complex flow with many interactions
between C++ and JS, there's no ResultCatcher object
during some parts of the test.

The solution is to observe the failure notifications
from the JS side, similarly to how ResultCatcher does
that.

A possible follow-up could be to extend this extra
safety measure to all extension API tests, but for the
beginning we're only addressing our local issue.

Bug: 1232459
Change-Id: Icf961eed6ec58bdc2994644b5c6ca98d24d6b022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3048483
Reviewed-by: Fabian Sommer <fabiansommer@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#905399}