Google Git
Sign in
chromium / chromium / src / 934524a70a91a77869c77a6783187b568862f87f
commit934524a70a91a77869c77a6783187b568862f87f[log] [tgz]
authorFahad Mansoor <fahadmansoor@google.com>Thu Dec 08 11:29:56 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Dec 08 11:29:56 2022
tree2cf82400c39a49776c960a2931f85f29623a7812
parent359eaefafc1d55d1c2e6bfd43fd0489d373bb1c9 [diff]
[CrOS Cellular] Add input validation to <apn-detail-dialog>

- Added a placeholder error message whenever the user enters more
 than 63 characters.
- Added a regex and placeholder error message when the user
enters non-ASCII characters.
- Added an asterisk next to the APN field.
- Disabled the Add button when an invalid or empty input is detected.

Screenshot:
(Non-ascii) https://screenshot.googleplex.com/C4na3CC6NCbXfCp.png
(Input too long) https://screenshot.googleplex.com/BWou5qqYWjFwwBK.png
(empty) https://screenshot.googleplex.com/3GcahmJ9NM8gxSZ.png

Test:
autoninja -C out/Default/ browser_tests && testing/xvfb.py ./out/Default/browser_tests --gtest_filter=*ApnDetailDialog*

Bug: b:162365553
Change-Id: I2b8bb2fe033180a45fe6eb37a2483602503f1081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4076209
Reviewed-by: Chad Duffin <chadduffin@chromium.org>
Reviewed-by: Gordon Seto <gordonseto@google.com>
Commit-Queue: Fahad Mansoor <fahadmansoor@google.com>
Cr-Commit-Position: refs/heads/main@{#1080862}
5 files changed
tree: 2cf82400c39a49776c960a2931f85f29623a7812
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.