[Tab Grid Dialog] Cleanup and docs around BINDING_TOKEN

Added the requested comments as per previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/4684992

Having spent some additional time considering the INDIVIDUAL_KEYS
proposal it is likely to cause more headaches than fixes.
1) Future developers need to now know about INDIVIDUAL_KEYS and
   whether any new property complies. The same could be said about
   BINDING_TOKEN, although that behavior is less nuanced to grasp.
2) Very few properties can safely be INDIVIDUAL_KEYS. At present,
   most properties depend on state tracked in the Mediator:
   * ADD_BUTTON_CLICK_LISTENER for metrics.
   * COLLAPSE_BUTTON_CONTENT_DESCRIPTION for the stored title.
   * TEXT_WATCHER to track title correctly.
   It is surprising this hadn't already caused issues in the past.
   In fact, it is likely some of our UserActions have been
   miscounted as a result of this.

Admittedly this should be safe for shared things like colors, but it is
easier to reason about if the state of the UI is self consistent with
the active model rather than potentially having stale state.

It is true that developers just have to worry about null checks.
However, if something is actually broken by setting it to null the unit
test TabGridPanelViewBinderTest#testBindingToken() should catch the
issue.

Fixed: 1464665
Change-Id: I5e139cca541b64e4670fc1b00eb0a4011f10cacb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4706924
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173459}
1 file changed
tree: b34e991ee3dfa9cc5b565b9075367ca08c65450b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.