Google Git
Sign in
chromium / chromium / src / 9450cfc0cf25d947fedd9fd5466b48a55dc8d227
commit9450cfc0cf25d947fedd9fd5466b48a55dc8d227[log] [tgz]
authorSam McNally <sammc@chromium.org>Thu Jun 22 07:41:51 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 22 07:41:51 2023
tree337db692c8e539ad68001ffde4f99f428eb9c862
parent783d82b1dfb84fe034ce0983478c365d75b1804d [diff]
Use Area64() for touch transform controller area calculations.

In the past, there was a touch controller, that when initialised with
the right interleaving with another touch device on the same I2C bus,
reported incorrect, and quite large bounds whose area overflowed the int
returned by gfx::Size::GetArea(). A workaround was added to ignore any
touch devices with an overflowing area.

However, there exist touch devices with a resolution high enough that
this isn't sufficient. Fortunately, since that original workaround,
gfx::Size::Area64() has been added, returning area as a uint64_t, which
does not have the risk of overflowing. Switch to Area64() for both
display and touch device areas and remove the filtering out of
previously-overflowing touch devices.

Bug: b:282082569
Change-Id: Icb279a1f23b81f47b7791f7c4640da386ab10968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4635060
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1161072}
4 files changed
tree: 337db692c8e539ad68001ffde4f99f428eb9c862
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.