Google Git
Sign in
chromium / chromium / src / 945cdda68e2eb0dd72b446c09990adbb51673b5b
commit945cdda68e2eb0dd72b446c09990adbb51673b5b[log] [tgz]
authorCalder Kitagawa <ckitagawa@chromium.org>Thu May 02 17:14:50 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 02 17:14:50 2024
tree229b06776689525db49e9fb6ff3f77d73a019330
parent1ca724d95889658855d03343be9465f6d9809009 [diff]
[M125][Hub] Disable browser controls while visible

On LFF there is a seemingly few pixel "overlap" between the android
toolbar and the Hub's toolbar (at the bottom). For some reason in this
region click events on the Hub can "pass through" to the Toolbar. (This
is not an issue on phones). I suspect this is related to the prior
ability for the toolbar to reparent atop the Tab Switcher (although I
cannot find where this happens). As an interim solution hide the toolbar
Android view while the Hub is fully visible to prevent touch inputs from
passing through to the toolbar.

(cherry picked from commit 471d0795a39bbc4d47bef8e4f7102ce53cffc98e)

Fixed: 337616153
Change-Id: I8ddcda80145811774f7e48784960a54dc35d443b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493335
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1293763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5508895
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#600}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
2 files changed
tree: 229b06776689525db49e9fb6ff3f77d73a019330
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.