commit 94c312c687afe926368f063f7a4464f50b06c27b
author Arthur Milchior <arthurmilchior@chromium.org> Tue Dec 03 15:31:19 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 03 15:31:19 2024
tree f5a21256bad0592fa2cdd45574431dfbccc3b2cc
parent 9156503a18a6e7fbb32cdb5317b3933f30e6dd67

[iOS]Browser’s unset its coordinators after stopping them.

Usually, when a coordinator is stopped, it’s set to nil or at least
to a new object.
This is now done almost systematically in the browser coordinator.

The only exception is the NTP, because:
* it can be restarted after being stopped,
* it is given as property’s value to many other objects.

Those other coordinators were not sent to any other objects, and
were always set to new object before being started. Also, even when
its properties where accessed, it’s relatively easy to see this
should not be a change in behaviour. Indeed:
* No calls are made to `pageInfoCoordinator` and
`textZoomCoordinator`
* most method call to the `FindBarCoordinator` are done in the
implementation of the find bar delegate. The only exception is a
call to the method that requests to lose the focus, which should
already have no effect if the coordinator is stopped.
* the only access to the PasskitCoordinator were to access the
passes. Those passses are set to nil when the coordinator is
stopped, so it’s certain the value returned is not changed if the
code were accidentally executed.

Bug: None
Change-Id: I8d64cff3897961b29e8ab255f44b67ce52c5134f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049582
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391005}